Problem when dealing with empty arrays #2

New Issue

maxmitti · 2020-08-12T15:04:10+03:00

maxmitti commented

2020-08-12 15:04:10 +03:00

I am facing problems when parsing empty arrays.

Here is a reduced example:

$done = false;
$json = new \JSONStream(function() use(&$done) {
    if($done) {
    return '';
    }
    $done = true;
    return '{"foo":[]}';
});

$json->enterObject();

$json->readValue($k);
print $k;

$json->enterArray();

print $json->readValue($v) ? $v : 'false';

$json->exitArray();

print $json->readValue($v) ? $v : 'false';
$json->exitObject();

I would expect this code to print foo false false and not throw any exception.

Actually, the last readValue throws an exception instead of returning false.
If instead omitting the last readValue exitObject throws an exception.

After further testing, it also seems to omit the last array value, e.g. with the JSON string ´{"foo":[123, 456]}´ it reads 123 successfully, but returns false on the second readValue already.

Edit: It actually stores 456 in $v, but also returns false. I am not sure if that is intended or not.

Apart from that your parser works great and is nice to use :)

I am facing problems when parsing empty arrays. Here is a reduced example: ``` $done = false; $json = new \JSONStream(function() use(&$done) { if($done) { return ''; } $done = true; return '{"foo":[]}'; }); $json->enterObject(); $json->readValue($k); print $k; $json->enterArray(); print $json->readValue($v) ? $v : 'false'; $json->exitArray(); print $json->readValue($v) ? $v : 'false'; $json->exitObject(); ``` I would expect this code to print foo false false and not throw any exception. Actually, the last readValue throws an exception instead of returning false. If instead omitting the last readValue exitObject throws an exception. After further testing, it also seems to omit the last array value, e.g. with the JSON string ´{"foo":[123, 456]}´ it reads 123 successfully, but returns false on the second readValue already. **Edit**: It actually stores 456 in $v, but also returns false. I am not sure if that is intended or not. Apart from that your parser works great and is nice to use :)

maxmitti referenced this issue

2020-08-15 19:29:19 +03:00

Fixes for #2 #3

maxmitti closed this issue

2020-08-20 17:08:03 +03:00

Sign in to join this conversation.