vitalif
/
fusego
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Updated a TODO.

geesefs-0-30-9
Aaron Jacobs 2015-08-12 00:48:00 +00:00
parent b0a4566c53
commit ed6f72d078
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
connection.go
View File

@ -165,7 +165,11 @@ func (c *Connection) Init() (err error) {
// Tell the kernel not to use pitifully small 4 KiB writes.
initOp.Flags |= fusekernel.InitBigWrites
// TODO(jacobsa): Add comments motivating this.
// TODO(jacobsa): Make this opt out and discuss benefits and caveats:
// * Write performance may be better (cf. http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/13923)
// * (Discuss what writeback caching even means)
// * File systems need to implement setattr for dealing with kernel's stored time (find code reference)
// * File systems no longer "own" mtime; kernel will cache it even if no writes (cf. http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/14808)
initOp.Flags |= fusekernel.InitWritebackCache
c.Reply(ctx, nil)