From 14b2f49f4d92fa911c1f37cd2707488164c2ed16 Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Sat, 30 Nov 2019 23:56:24 +0300 Subject: [PATCH] FIXME --- blockstore.cpp | 4 ++++ blockstore_flush.cpp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/blockstore.cpp b/blockstore.cpp index aeabcee5..86caee6b 100644 --- a/blockstore.cpp +++ b/blockstore.cpp @@ -163,6 +163,10 @@ void blockstore::loop() { dequeue_op = dequeue_stable(op); } + else if ((op->flags & OP_TYPE_MASK) == OP_DELETE) + { + // FIXME: Implement DELETE + } if (dequeue_op) { submit_queue.erase(op_ptr); diff --git a/blockstore_flush.cpp b/blockstore_flush.cpp index 96c1d100..aab441b6 100644 --- a/blockstore_flush.cpp +++ b/blockstore_flush.cpp @@ -285,7 +285,7 @@ resume_0: } // Also we need to submit the metadata read. We do a read-modify-write for every operation. // But we must check if the same sector is already in memory. - // Another option is to keep all raw metadata in memory all the time. Maybe I'll do it sometime... + // Another option is to keep all raw metadata in memory all the time. FIXME: Maybe add this mode. // And yet another option is to use LSM trees for metadata, but it sophisticates everything a lot, // so I'll avoid it as long as I can. meta_sector = ((clean_loc >> bs->block_order) / (512 / sizeof(clean_disk_entry))) * 512;