diff --git a/Makefile b/Makefile index 85e4bf40..33840428 100644 --- a/Makefile +++ b/Makefile @@ -87,7 +87,7 @@ dump_journal.o: dump_journal.cpp allocator.h blockstore.h blockstore_flush.h blo g++ $(CXXFLAGS) -c -o $@ $< epoll_manager.o: epoll_manager.cpp epoll_manager.h ringloop.h timerfd_manager.h g++ $(CXXFLAGS) -c -o $@ $< -etcd_state_client.o: etcd_state_client.cpp base64.h etcd_state_client.h http_client.h json11/json11.hpp object_id.h osd_id.h osd_ops.h pg_states.h timerfd_manager.h +etcd_state_client.o: etcd_state_client.cpp base64.h etcd_state_client.h http_client.h json11/json11.hpp object_id.h osd_id.h osd_ops.h pg_states.h ringloop.h timerfd_manager.h g++ $(CXXFLAGS) -c -o $@ $< fio_cluster.o: fio_cluster.cpp cluster_client.h epoll_manager.h etcd_state_client.h fio/fio.h fio/optgroup.h http_client.h json11/json11.hpp messenger.h object_id.h osd_id.h osd_ops.h ringloop.h timerfd_manager.h g++ $(CXXFLAGS) -c -o $@ $< @@ -95,7 +95,7 @@ fio_engine.o: fio_engine.cpp blockstore.h fio/fio.h fio/optgroup.h json11/json11 g++ $(CXXFLAGS) -c -o $@ $< fio_sec_osd.o: fio_sec_osd.cpp fio/fio.h fio/optgroup.h object_id.h osd_id.h osd_ops.h rw_blocking.h g++ $(CXXFLAGS) -c -o $@ $< -http_client.o: http_client.cpp http_client.h json11/json11.hpp timerfd_manager.h +http_client.o: http_client.cpp http_client.h json11/json11.hpp ringloop.h timerfd_manager.h g++ $(CXXFLAGS) -c -o $@ $< messenger.o: messenger.cpp json11/json11.hpp messenger.h object_id.h osd_id.h osd_ops.h ringloop.h timerfd_manager.h g++ $(CXXFLAGS) -c -o $@ $< @@ -149,5 +149,5 @@ test_blockstore.o: test_blockstore.cpp blockstore.h object_id.h ringloop.h timer g++ $(CXXFLAGS) -c -o $@ $< timerfd_interval.o: timerfd_interval.cpp ringloop.h timerfd_interval.h g++ $(CXXFLAGS) -c -o $@ $< -timerfd_manager.o: timerfd_manager.cpp timerfd_manager.h +timerfd_manager.o: timerfd_manager.cpp ringloop.h timerfd_manager.h g++ $(CXXFLAGS) -c -o $@ $< diff --git a/osd.cpp b/osd.cpp index f73dec79..f1e2982e 100644 --- a/osd.cpp +++ b/osd.cpp @@ -44,7 +44,8 @@ osd_t::osd_t(blockstore_config_t & config, blockstore_t *bs, ring_loop_t *ringlo throw std::runtime_error(std::string("epoll_create: ") + strerror(errno)); } - this->tfd = new timerfd_manager_t([this](int fd, std::function handler) { set_fd_handler(fd, handler); }); + this->tfd = new timerfd_manager_t(ringloop); + this->tfd->set_fd_handler = [this](int fd, std::function handler) { set_fd_handler(fd, handler); }; this->tfd->set_timer(print_stats_interval*1000, true, [this](int timer_id) { print_stats(); diff --git a/timerfd_manager.cpp b/timerfd_manager.cpp index c7bc736b..192ae6eb 100644 --- a/timerfd_manager.cpp +++ b/timerfd_manager.cpp @@ -1,29 +1,24 @@ #include #include -#include #include -#include -#include #include "timerfd_manager.h" -timerfd_manager_t::timerfd_manager_t(std::function)> set_fd_handler) +timerfd_manager_t::timerfd_manager_t(ring_loop_t *ringloop) { - this->set_fd_handler = set_fd_handler; wait_state = 0; timerfd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK); if (timerfd < 0) { throw std::runtime_error(std::string("timerfd_create: ") + strerror(errno)); } - set_fd_handler(timerfd, [this](int fd, int events) - { - handle_readable(); - }); + consumer.loop = [this]() { loop(); }; + ringloop->register_consumer(&consumer); + this->ringloop = ringloop; } timerfd_manager_t::~timerfd_manager_t() { - set_fd_handler(timerfd, NULL); + ringloop->unregister_consumer(&consumer); close(timerfd); } @@ -53,6 +48,7 @@ int timerfd_manager_t::set_timer(uint64_t millis, bool repeat, std::functionget_sqe(); + if (!sqe) + { + return; + } + ring_data_t *data = ((ring_data_t*)sqe->user_data); + my_uring_prep_poll_add(sqe, timerfd, POLLIN); + data->callback = [this](ring_data_t *data) + { + if (data->res < 0) + { + throw std::runtime_error(std::string("waiting for timer failed: ") + strerror(-data->res)); + } + handle_readable(); + set_wait(); + }; + wait_state = 3; + } +} diff --git a/timerfd_manager.h b/timerfd_manager.h index 8f438e38..5d292b1d 100644 --- a/timerfd_manager.h +++ b/timerfd_manager.h @@ -1,8 +1,7 @@ #pragma once #include -#include -#include +#include "ringloop.h" struct timerfd_timer_t { @@ -20,15 +19,20 @@ class timerfd_manager_t int nearest = -1; int id = 1; std::vector timers; + ring_loop_t *ringloop; + ring_consumer_t consumer; void inc_timer(timerfd_timer_t & t); void set_nearest(); void trigger_nearest(); void handle_readable(); + void set_wait(); + void loop(); public: + // FIXME shouldn't be here std::function)> set_fd_handler; - timerfd_manager_t(std::function)> set_fd_handler); + timerfd_manager_t(ring_loop_t *ringloop); ~timerfd_manager_t(); int set_timer(uint64_t millis, bool repeat, std::function callback); void clear_timer(int timer_id);