Fix reenterability around set_timer

nfs-proxy-old
Vitaliy Filippov 1 year ago
parent 88402e6eb6
commit a3fb1d4c98
  1. 20
      src/http_client.cpp

@ -163,6 +163,17 @@ void http_co_t::send_request(const std::string & host, const std::string & reque
this->sent = 0;
this->response_callback = response_callback;
this->parsed = {};
if (state == HTTP_CO_KEEPALIVE)
{
state = HTTP_CO_SENDING_REQUEST;
submit_send();
}
else
{
start_connection();
}
// Do it _after_ state assignment because set_timer() can actually trigger
// other timers and requests (reenterability is our friend)
if (request_timeout > 0)
{
timeout_id = tfd->set_timer(request_timeout, false, [this](int timer_id)
@ -183,15 +194,6 @@ void http_co_t::send_request(const std::string & host, const std::string & reque
stackout();
});
}
if (state == HTTP_CO_KEEPALIVE)
{
state = HTTP_CO_SENDING_REQUEST;
submit_send();
}
else
{
start_connection();
}
stackout();
}

Loading…
Cancel
Save