Browse Source

Safe stop procedure

blocking-uring-test
Vitaliy Filippov 3 years ago
parent
commit
be3015169f
  1. 27
      blockstore.cpp
  2. 6
      blockstore.h
  3. 5
      blockstore_flush.cpp
  4. 1
      blockstore_flush.h
  5. 1
      blockstore_sync.cpp

27
blockstore.cpp

@ -176,9 +176,32 @@ void blockstore::loop()
}
}
bool blockstore::stop()
bool blockstore::is_safe_to_stop()
{
return false;
// It's safe to stop blockstore when there are no in-flight operations,
// no in-progress syncs and flusher isn't doing anything
if (submit_queue.size() > 0 || in_progress_syncs.size() > 0 || flusher->is_active())
{
return false;
}
if (unsynced_big_writes.size() > 0 || unsynced_small_writes.size() > 0)
{
if (!stop_sync_submitted)
{
// We should sync the blockstore before unmounting
blockstore_operation *op = new blockstore_operation;
op->flags = OP_SYNC;
op->buf = NULL;
op->callback = [&](blockstore_operation *op)
{
delete op;
};
enqueue_op(op);
stop_sync_submitted = true;
}
return false;
}
return true;
}
void blockstore::check_wait(blockstore_operation *op)

6
blockstore.h

@ -271,6 +271,8 @@ class blockstore
ring_loop_t *ringloop;
bool stop_sync_submitted;
inline struct io_uring_sqe* get_sqe()
{
return ringloop->get_sqe();
@ -327,12 +329,14 @@ public:
// Event loop
void loop();
// Returns true when blockstore is ready to process operations
// (Although you're free to enqueue them before that)
bool is_started();
// Returns true when it's safe to destroy the instance. If destroying the instance
// requires to purge some queues, starts that process. Should be called in the event
// loop until it returns true.
bool stop();
bool is_safe_to_stop();
// Submission
void enqueue_op(blockstore_operation *op);

5
blockstore_flush.cpp

@ -41,6 +41,11 @@ journal_flusher_t::~journal_flusher_t()
delete[] co;
}
bool journal_flusher_t::is_active()
{
return active_flushers > 0 || flush_queue.size() > 0;
}
void journal_flusher_t::loop()
{
for (int i = 0; i < flusher_count; i++)

1
blockstore_flush.h

@ -70,6 +70,7 @@ public:
journal_flusher_t(int flusher_count, blockstore *bs);
~journal_flusher_t();
void loop();
bool is_active();
void queue_flush(obj_ver_id oid);
void unshift_flush(obj_ver_id oid);
};

1
blockstore_sync.cpp

@ -11,6 +11,7 @@ int blockstore::dequeue_sync(blockstore_operation *op)
{
if (op->sync_state == 0)
{
stop_sync_submitted = false;
op->sync_big_writes.swap(unsynced_big_writes);
op->sync_small_writes.swap(unsynced_small_writes);
if (op->sync_big_writes.size() > 0)

Loading…
Cancel
Save