From be4087d9d28a75067b95988980741bc118ff174f Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Sun, 5 Jun 2022 00:06:53 +0300 Subject: [PATCH] Add a FIXME to test_interrupted_rebalance --- tests/test_change_pg_count.sh | 2 +- tests/test_interrupted_rebalance.sh | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/test_change_pg_count.sh b/tests/test_change_pg_count.sh index d695b118..aa28067b 100755 --- a/tests/test_change_pg_count.sh +++ b/tests/test_change_pg_count.sh @@ -5,7 +5,7 @@ PG_COUNT=16 . `dirname $0`/run_3osds.sh -NOBJ=$((128*8/PG_DATA_SIZE)) +NOBJ=$(((128*8+PG_DATA_SIZE-1)/PG_DATA_SIZE)) LD_PRELOAD="build/src/libfio_vitastor.so" \ fio -thread -name=test -ioengine=build/src/libfio_vitastor.so -bs=4M -direct=1 -iodepth=1 -fsync=1 -rw=write \ diff --git a/tests/test_interrupted_rebalance.sh b/tests/test_interrupted_rebalance.sh index e0c06213..e78e8d57 100755 --- a/tests/test_interrupted_rebalance.sh +++ b/tests/test_interrupted_rebalance.sh @@ -34,9 +34,10 @@ try_reweight 5 1 wait_finish_rebalance 60 # Check that PGs never had degraded objects ! -if grep has_degraded ./testdata/mon.log; then - format_error "Some copies of objects were lost during interrupted rebalancings" -fi +# FIXME: In fact, the test doesn't guarantee it because PGs aren't always peered only with full prior OSD sets :-( +#if grep has_degraded ./testdata/mon.log; then +# format_error "Some copies of objects were lost during interrupted rebalancings" +#fi # Check that no objects are lost ! nobj=`$ETCDCTL get --prefix '/vitastor/pg/stats' --print-value-only | jq -s '[ .[].object_count ] | reduce .[] as $num (0; .+$num)'`