Don't return error from FileSystem methods.

geesefs-0-30-9
Aaron Jacobs 2015-03-25 09:53:26 +11:00
parent eeac7182e5
commit 93d1bc181f
1 changed files with 46 additions and 41 deletions

View File

@ -26,35 +26,40 @@ import (
// loop" that switches on op types, instead receiving typed method calls // loop" that switches on op types, instead receiving typed method calls
// directly. // directly.
// //
// Each method should fill in appropriate response fields for the supplied op // Each method is responsible for calling Respond on the supplied op.
// and return an error status, but not call Repand.
// //
// See NotImplementedFileSystem for a convenient way to embed default // See NotImplementedFileSystem for a convenient way to embed default
// implementations for methods you don't care about. // implementations for methods you don't care about.
type FileSystem interface { type FileSystem interface {
Init(*fuseops.InitOp) error Init(*fuseops.InitOp)
LookUpInode(*fuseops.LookUpInodeOp) error LookUpInode(*fuseops.LookUpInodeOp)
GetInodeAttributes(*fuseops.GetInodeAttributesOp) error GetInodeAttributes(*fuseops.GetInodeAttributesOp)
SetInodeAttributes(*fuseops.SetInodeAttributesOp) error SetInodeAttributes(*fuseops.SetInodeAttributesOp)
ForgetInode(*fuseops.ForgetInodeOp) error ForgetInode(*fuseops.ForgetInodeOp)
MkDir(*fuseops.MkDirOp) error MkDir(*fuseops.MkDirOp)
CreateFile(*fuseops.CreateFileOp) error CreateFile(*fuseops.CreateFileOp)
RmDir(*fuseops.RmDirOp) error RmDir(*fuseops.RmDirOp)
Unlink(*fuseops.UnlinkOp) error Unlink(*fuseops.UnlinkOp)
OpenDir(*fuseops.OpenDirOp) error OpenDir(*fuseops.OpenDirOp)
ReadDir(*fuseops.ReadDirOp) error ReadDir(*fuseops.ReadDirOp)
ReleaseDirHandle(*fuseops.ReleaseDirHandleOp) error ReleaseDirHandle(*fuseops.ReleaseDirHandleOp)
OpenFile(*fuseops.OpenFileOp) error OpenFile(*fuseops.OpenFileOp)
ReadFile(*fuseops.ReadFileOp) error ReadFile(*fuseops.ReadFileOp)
WriteFile(*fuseops.WriteFileOp) error WriteFile(*fuseops.WriteFileOp)
SyncFile(*fuseops.SyncFileOp) error SyncFile(*fuseops.SyncFileOp)
FlushFile(*fuseops.FlushFileOp) error FlushFile(*fuseops.FlushFileOp)
ReleaseFileHandle(*fuseops.ReleaseFileHandleOp) error ReleaseFileHandle(*fuseops.ReleaseFileHandleOp)
} }
// Create a fuse.Server that serves ops by calling the associated FileSystem // Create a fuse.Server that handles ops by calling the associated FileSystem
// method and then calling Op.Respond with the resulting error. Unsupported ops // method.Respond with the resulting error. Unsupported ops are responded to
// are responded to directly with ENOSYS. // directly with ENOSYS.
//
// FileSystem methods are called ine exactly the order of supported ops
// received by the connection, on a single goroutine. The methods should
// probably not block, instead continuing long-running operations in the
// background. Note however that there are subtleties here: for example, you
// probably want to serialize the order of write and flush operations.
func NewFileSystemServer(fs FileSystem) fuse.Server { func NewFileSystemServer(fs FileSystem) fuse.Server {
return fileSystemServer{fs} return fileSystemServer{fs}
} }
@ -79,58 +84,58 @@ func (s fileSystemServer) ServeOps(c *fuse.Connection) {
op.Respond(fuse.ENOSYS) op.Respond(fuse.ENOSYS)
case *fuseops.InitOp: case *fuseops.InitOp:
op.Respond(s.fs.Init(typed)) s.fs.Init(typed)
case *fuseops.LookUpInodeOp: case *fuseops.LookUpInodeOp:
op.Respond(s.fs.LookUpInode(typed)) s.fs.LookUpInode(typed)
case *fuseops.GetInodeAttributesOp: case *fuseops.GetInodeAttributesOp:
op.Respond(s.fs.GetInodeAttributes(typed)) s.fs.GetInodeAttributes(typed)
case *fuseops.SetInodeAttributesOp: case *fuseops.SetInodeAttributesOp:
op.Respond(s.fs.SetInodeAttributes(typed)) s.fs.SetInodeAttributes(typed)
case *fuseops.ForgetInodeOp: case *fuseops.ForgetInodeOp:
op.Respond(s.fs.ForgetInode(typed)) s.fs.ForgetInode(typed)
case *fuseops.MkDirOp: case *fuseops.MkDirOp:
op.Respond(s.fs.MkDir(typed)) s.fs.MkDir(typed)
case *fuseops.CreateFileOp: case *fuseops.CreateFileOp:
op.Respond(s.fs.CreateFile(typed)) s.fs.CreateFile(typed)
case *fuseops.RmDirOp: case *fuseops.RmDirOp:
op.Respond(s.fs.RmDir(typed)) s.fs.RmDir(typed)
case *fuseops.UnlinkOp: case *fuseops.UnlinkOp:
op.Respond(s.fs.Unlink(typed)) s.fs.Unlink(typed)
case *fuseops.OpenDirOp: case *fuseops.OpenDirOp:
op.Respond(s.fs.OpenDir(typed)) s.fs.OpenDir(typed)
case *fuseops.ReadDirOp: case *fuseops.ReadDirOp:
op.Respond(s.fs.ReadDir(typed)) s.fs.ReadDir(typed)
case *fuseops.ReleaseDirHandleOp: case *fuseops.ReleaseDirHandleOp:
op.Respond(s.fs.ReleaseDirHandle(typed)) s.fs.ReleaseDirHandle(typed)
case *fuseops.OpenFileOp: case *fuseops.OpenFileOp:
op.Respond(s.fs.OpenFile(typed)) s.fs.OpenFile(typed)
case *fuseops.ReadFileOp: case *fuseops.ReadFileOp:
op.Respond(s.fs.ReadFile(typed)) s.fs.ReadFile(typed)
case *fuseops.WriteFileOp: case *fuseops.WriteFileOp:
op.Respond(s.fs.WriteFile(typed)) s.fs.WriteFile(typed)
case *fuseops.SyncFileOp: case *fuseops.SyncFileOp:
op.Respond(s.fs.SyncFile(typed)) s.fs.SyncFile(typed)
case *fuseops.FlushFileOp: case *fuseops.FlushFileOp:
op.Respond(s.fs.FlushFile(typed)) s.fs.FlushFile(typed)
case *fuseops.ReleaseFileHandleOp: case *fuseops.ReleaseFileHandleOp:
op.Respond(s.fs.ReleaseFileHandle(typed)) s.fs.ReleaseFileHandle(typed)
} }
} }
} }