Pay attention to DisableWritebackCaching.
parent
842af25013
commit
f40a24c8d5
|
@ -57,6 +57,7 @@ const maxReadahead = 1 << 20
|
||||||
|
|
||||||
// A connection to the fuse kernel process.
|
// A connection to the fuse kernel process.
|
||||||
type Connection struct {
|
type Connection struct {
|
||||||
|
cfg MountConfig
|
||||||
debugLogger *log.Logger
|
debugLogger *log.Logger
|
||||||
errorLogger *log.Logger
|
errorLogger *log.Logger
|
||||||
|
|
||||||
|
@ -65,9 +66,6 @@ type Connection struct {
|
||||||
dev *os.File
|
dev *os.File
|
||||||
protocol fusekernel.Protocol
|
protocol fusekernel.Protocol
|
||||||
|
|
||||||
// The context from which all op contexts inherit.
|
|
||||||
parentCtx context.Context
|
|
||||||
|
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
|
|
||||||
// A map from fuse "unique" request ID (*not* the op ID for logging used
|
// A map from fuse "unique" request ID (*not* the op ID for logging used
|
||||||
|
@ -94,15 +92,15 @@ type opState struct {
|
||||||
//
|
//
|
||||||
// The loggers may be nil.
|
// The loggers may be nil.
|
||||||
func newConnection(
|
func newConnection(
|
||||||
parentCtx context.Context,
|
cfg MountConfig,
|
||||||
debugLogger *log.Logger,
|
debugLogger *log.Logger,
|
||||||
errorLogger *log.Logger,
|
errorLogger *log.Logger,
|
||||||
dev *os.File) (c *Connection, err error) {
|
dev *os.File) (c *Connection, err error) {
|
||||||
c = &Connection{
|
c = &Connection{
|
||||||
|
cfg: cfg,
|
||||||
debugLogger: debugLogger,
|
debugLogger: debugLogger,
|
||||||
errorLogger: errorLogger,
|
errorLogger: errorLogger,
|
||||||
dev: dev,
|
dev: dev,
|
||||||
parentCtx: parentCtx,
|
|
||||||
cancelFuncs: make(map[uint64]func()),
|
cancelFuncs: make(map[uint64]func()),
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -165,12 +163,10 @@ func (c *Connection) Init() (err error) {
|
||||||
// Tell the kernel not to use pitifully small 4 KiB writes.
|
// Tell the kernel not to use pitifully small 4 KiB writes.
|
||||||
initOp.Flags |= fusekernel.InitBigWrites
|
initOp.Flags |= fusekernel.InitBigWrites
|
||||||
|
|
||||||
// TODO(jacobsa): Make this opt out and discuss benefits and caveats:
|
// Enable writeback caching if the user hasn't asked us not to.
|
||||||
// * Write performance may be better (cf. http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/13923)
|
if !c.cfg.DisableWritebackCaching {
|
||||||
// * (Discuss what writeback caching even means)
|
initOp.Flags |= fusekernel.InitWritebackCache
|
||||||
// * File systems need to implement setattr for dealing with kernel's stored time (find code reference)
|
}
|
||||||
// * File systems no longer "own" mtime; kernel will cache it even if no writes (cf. http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/14808)
|
|
||||||
initOp.Flags |= fusekernel.InitWritebackCache
|
|
||||||
|
|
||||||
c.Reply(ctx, nil)
|
c.Reply(ctx, nil)
|
||||||
return
|
return
|
||||||
|
@ -234,7 +230,7 @@ func (c *Connection) beginOp(
|
||||||
opCode uint32,
|
opCode uint32,
|
||||||
fuseID uint64) (ctx context.Context) {
|
fuseID uint64) (ctx context.Context) {
|
||||||
// Start with the parent context.
|
// Start with the parent context.
|
||||||
ctx = c.parentCtx
|
ctx = c.cfg.OpContext
|
||||||
|
|
||||||
// Set up a cancellation function.
|
// Set up a cancellation function.
|
||||||
//
|
//
|
||||||
|
|
8
mount.go
8
mount.go
|
@ -67,14 +67,14 @@ func Mount(
|
||||||
}
|
}
|
||||||
|
|
||||||
// Choose a parent context for ops.
|
// Choose a parent context for ops.
|
||||||
opContext := config.OpContext
|
cfgCopy := *config
|
||||||
if opContext == nil {
|
if cfgCopy.OpContext == nil {
|
||||||
opContext = context.Background()
|
cfgCopy.OpContext = context.Background()
|
||||||
}
|
}
|
||||||
|
|
||||||
// Create a Connection object wrapping the device.
|
// Create a Connection object wrapping the device.
|
||||||
connection, err := newConnection(
|
connection, err := newConnection(
|
||||||
opContext,
|
cfgCopy,
|
||||||
config.DebugLogger,
|
config.DebugLogger,
|
||||||
config.ErrorLogger,
|
config.ErrorLogger,
|
||||||
dev)
|
dev)
|
||||||
|
|
Loading…
Reference in New Issue